Skip to content

Concrete implementation of render current frame and batch render. - #4704

Open
ppt-adsk wants to merge 1 commit into
devfrom
tremblp/HYDRA-2391/render_setup_render_pulldown_implementation
Open

Concrete implementation of render current frame and batch render.#4704
ppt-adsk wants to merge 1 commit into
devfrom
tremblp/HYDRA-2391/render_setup_render_pulldown_implementation

Conversation

@ppt-adsk

Copy link
Copy Markdown
Collaborator

No description provided.

@ppt-adsk
ppt-adsk requested a review from seando-adsk August 18, 2026 18:09
@ppt-adsk ppt-adsk self-assigned this Aug 18, 2026
Comment thread lib/usd/ui/renderSetup/rendering/mayaBatchRenderResult.cpp
Comment thread lib/usd/ui/renderSetup/rendering/mayaBatchRenderHandler.h
// without a renderer name (command would read it). PPT, 10-Aug-2026.
MGlobal::displayInfo(MString("MayaRenderCurrentFrameHandler::render() called."));
std::ostringstream cmdStr;
cmdStr << "hydraRender -r " << rendererName.asChar() << " -cf";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does hydraRender return anything itself? render returns the path of the image generated

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently hydraRender returns nothing.

For render current frame, conceptually this is possible, though tricky, as we would have to inspect the Hydra render settings, and report the written image for each render product (there could be more than one).

For a sequence render, would we return a vector of vectors of rendered images, the vector of rendered images for each sequence on a single render product, then the vector of that for all render products?

Before implementing anything I would like to figure out if there is a real need for this. From a logical standpoint if the render reports success, then all images for all render products were written to their location.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i was asking from the POV of that conversation that happened when someone was saying it was "really important" that the output image be opened (with the default OS image viewer for example) after rendering. Guess we figure this out later

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's a bit tricky given that you can output more than one render product.

namespace MayaUsdRenderSetup {

//! Placeholder.
bool MayaBatchRenderResult::isDone() const { return true; }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) Seems odd to me that both async and isDone be true

(even more minor) isAsync inlined, these not.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async means that progress will occur asynchronously.

isDone cannot be a constant. It is here only because it can't be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants