299 refactor frontend to backend 20 #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odate for storing the experiments properly.
…o be called updateExperimentName and now does an api call to the new [... expIdToUpdateName].tsx and utilises MongoDB. Needs to be tested.
bveal52
requested changes
Oct 23, 2024
rhit-windsors
requested changes
Oct 23, 2024
|
|
||
| const experiment = await db | ||
| .collection(COLLECTION_EXPERIMENTS) | ||
| .deleteOne({ '_id': expIdToDelete as any }); // Assuming expId is the unique identifier in the collection |
There was a problem hiding this comment.
Make sure that this returns what you are expecting
| return; | ||
| } | ||
|
|
||
| const experimentData: ExperimentData = req.body; |
There was a problem hiding this comment.
Is this actually ExperimentData? or just a JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look over this carefully