Skip to content

Conversation

@AdamGrzybkowski
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski commented Jun 13, 2025

Description

This PR makes some changes to the QE top bar and the profile card:

  1. The icon in the View button is changed to "external link".
  2. The email above the profile card is removed from the QE if the auth token is provided from a 3rd-party app.
  3. The font scaling inside the profile card is limited to 1.5f.
Screen_recording_20250616_094128.mp4

Testing Steps

  1. Launch the QE with and without the token - confirm the email visibility.
  2. Test the new icon in RTL - it should be mirrored.
  3. Test the font scaling and confirm it stops at a certain threshold.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 13, 2025

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App NameGravatar Demo
Commit6132b3b
Direct Downloadgravatar-demo-prototype-build-pr664-6132b3b.apk

@AdamGrzybkowski AdamGrzybkowski changed the title Adam/gra 192 QE Top section update Jun 16, 2025
@AdamGrzybkowski AdamGrzybkowski changed the title QE Top section update QE Top section updates Jun 16, 2025
@AdamGrzybkowski AdamGrzybkowski marked this pull request as ready for review June 16, 2025 07:42
Copy link
Contributor

@hamorillo hamorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for the changes! I left a minor question to discuss.

✅ Launch the QE with and without the token - confirm the email visibility.
✅ Test the new icon in RTL - it should be mirrored.
✅ Test the font scaling and confirm it stops at a certain threshold.

state = state,
modifier = Modifier.height(32.dp),
) {
Icon(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I wonder if (probably not now) we should replace the default icon in the UI library with this new icon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe iOS doesn't use the public component, so the new icon was changed only in the QE. That's why I didn't modify the public component as well. The icon can be easily modified (as we did here) so I don't think it's a big issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes total sense for this PR. I was thinking aloud. I agree that it's not a big issue.

@AdamGrzybkowski AdamGrzybkowski merged commit 1874f8b into trunk Jun 16, 2025
15 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/GRA-192 branch June 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Gravatar-Quickeditor Gravatar Quick Editor module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants