Skip to content

Hide the profile card on compact height and keyboard present #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025

Conversation

etoledom
Copy link
Contributor

Closes #741

Description

Small PRs which will hide the Profile card in the case the available height is compact and the keyboard is present.

CleanShot 2025-05-20 at 16 25 40

Testing Steps

  • Open the Quick Editor with About Editor scope
  • Start editing any field
  • Rotate the device to make it landscape
    • Check that the profile view is not present
    • Check that there's enough space to see the fields which is being edited.

@wpmobilebot
Copy link

wpmobilebot commented May 20, 2025

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2363
VersionPR #756
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit5c706dd
Installation URL2djmt8oh4sqtg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@etoledom
Copy link
Contributor Author

I'm considering also hiding the save button to have a clear view of the field (specially for the multiline one) 🤔

@pinarol
Copy link
Contributor

pinarol commented May 20, 2025

I'm considering also hiding the save button to have a clear view of the field (specially for the multiline one) 🤔

We can definitely try.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know if you want me to check again in case you also hide the Save button.

@etoledom
Copy link
Contributor Author

@pinarol - I've added a commit to also hide the save button. It looks like this:

CleanShot 2025-05-20 at 20 07 07

@pinarol
Copy link
Contributor

pinarol commented May 20, 2025

That looks good to me as well.

@etoledom etoledom merged commit a24701e into trunk May 21, 2025
8 checks passed
@etoledom etoledom deleted the etoledom/hide-card-landscape-keyboard branch May 21, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Editor adaptation to landscape
3 participants