-
Notifications
You must be signed in to change notification settings - Fork 26
Hide the profile card on compact height and keyboard present #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
App Name | Gravatar Prototype Build | |
Build Number | 2363 | |
Version | PR #756 | |
Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
Commit | 5c706dd | |
Installation URL | 2djmt8oh4sqtg |
I'm considering also hiding the save button to have a clear view of the field (specially for the multiline one) 🤔 |
We can definitely try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let me know if you want me to check again in case you also hide the Save button.
@pinarol - I've added a commit to also hide the save button. It looks like this: |
That looks good to me as well. |
…b.com/Automattic/Gravatar-SDK-iOS into etoledom/hide-card-landscape-keyboard
Closes #741
Description
Small PRs which will hide the Profile card in the case the available height is compact and the keyboard is present.
Testing Steps