Skip to content

Fixes contextual menu iPad presentation crashes #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

etoledom
Copy link
Contributor

Closes #745

Description

Small PR which fixes a crash on the demo app regarding presenting menu items on iPad.

Testing Steps

  • Run the demo app on an iPad
  • Go through all demo screens in the UIKit context.
  • Select all available option menus
    • Check that there are no crashes.

@etoledom etoledom requested a review from pinarol May 20, 2025 15:11
@etoledom etoledom self-assigned this May 20, 2025
@etoledom etoledom added Bug Something isn't working demoapp Demo App Changes [Priority] High labels May 20, 2025
@wpmobilebot
Copy link

wpmobilebot commented May 20, 2025

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2356
VersionPR #757
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commitd6405d0
Installation URL3jftbjig8j1f8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@etoledom etoledom merged commit cbc59ad into trunk May 21, 2025
8 checks passed
@etoledom etoledom deleted the etoledom/fix-demo-crashes-on-ipad branch May 21, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working demoapp Demo App Changes [Priority] High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo App crash: Config sheets presentation on iPad crashes.
3 participants