Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Jun 6, 2025

Closes #675

Description

This PR makes the page switch buttons on the profile card accessible with a label for Voice Over.

  • Note that the design itself is not good for accessibility, and grouping all the card together will make it difficult for the system to read out the image description. So I decided to go with the simpler route and name the buttons appropriately, even with the confusion of the position change for voice over users.

We also mix the textfield title and value together as one accessibility element in the About Editor page, which is the recommendation for these cases.

Testing Steps

  • Run the demo app
  • Go to Quick Editor demo
  • Present the quick editor with the Avatar & About scope
  • Turn ON Voice Over
    • Check that Voice Over reads the label on the page switch buttons.
    • Check that on the About Editor page, Voice Over reads the title and the fields content together, and does not interact with the title label.

@wpmobilebot
Copy link

wpmobilebot commented Jun 6, 2025

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2421
VersionPR #779
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commite4f9941
Installation URL5ln98vt5a2adg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good 🎉

@etoledom etoledom merged commit 7e8cd5c into release/3.4.0 Jun 9, 2025
8 checks passed
@etoledom etoledom deleted the etoledom/accessibility-mark-iii branch June 9, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants