Skip to content

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 25, 2025

See investigation from #133 and discussion in paaHJt-8BQ-p2


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@mokagio mokagio requested a review from a team June 25, 2025 01:40
@dangermattic
Copy link

1 Warning
⚠️ Please add an entry in the CHANGELOG.md file to describe the changes made by this PR

Generated by 🚫 Danger

@AliSoftware AliSoftware merged commit 3d5ad09 into trunk Jun 25, 2025
26 checks passed
@AliSoftware AliSoftware deleted the mokagio/cursorrules-update-ps1 branch June 25, 2025 07:55
@AliSoftware
Copy link
Contributor

Side note that I also created https://linear.app/a8c/issue/AINFRA-841 to at some point integrate PSScriptAnalyzer to lint PS1 scripts.

Not sure that linter would be able to detect missing calls to If ($LastExitCode -ne 0) { Exit $LastExitCode } after each command potentially failing, but would still be useful to have anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants