-
Notifications
You must be signed in to change notification settings - Fork 5
Install Python during windows setup and add new Visual Studio Build tools components #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
19d407b
to
f80bd61
Compare
d8b34b1
to
5e96155
Compare
…s setup" This reverts commit 5e96155.
Co-authored-by: Olivier Halligon <[email protected]>
…lNativeCompilationTools` Co-authored-by: Olivier Halligon <[email protected]>
b78c34d
to
fbdc993
Compare
…ws10SDKInstallation and update tests
fbdc993
to
fcebed7
Compare
b9fcf03
to
c4f50c9
Compare
@AliSoftware I think I addressed all the points. I struggled a bit with the unit tests later but everything seems to be finally working now 😌 |
$certificatePfxPath = "certificate.pfx" | ||
certutil -decode $certificateBinPath $certificatePfxPath | ||
Write-Output "Code signing certificate downloaded at: $((Get-Item $certificatePfxPath).FullName)" | ||
if ($env:SKIP_CERTIFICATE_DOWNLOAD -eq "true") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the reason why this is controlled by an env var and not a flag (aka param { [switch] … }
) like the others is because the skipping is only used for the tests so far?
But that made me wonder if the studio jobs running the Unit Tests might also not need the cert and want to skip it 🤔 💭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is only used for the tests so far?
Yes, that's the case so far. Also, this seemed more like a configuration rather than an API argument so the env var felt more appropriate.
if the studio jobs running the Unit Tests might also not need the cert
Good question. Imagining it still compiles the tested app in some way, perhaps they're still needed? But we can definitely try 👍
To fix the error seen in Automattic/studio#1594 (build), this PR implemented:
Being tested via Automattic/studio#1608
CHANGELOG.md
if necessary.