Skip to content

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Aug 6, 2025

Closes AINFRA-1096

Windows 10 SDK 20348 doesn't appear available for download via the VS code bootstrapping tool, but
19041 still works.

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@twstokes twstokes force-pushed the twstokes/win-sdk branch 2 times, most recently from 687cde8 to af7f90b Compare August 6, 2025 12:27
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but left a question.

I guess the plan is to soon support Win11 SDK anyway (in a separate PR with some refactor etc), so it's probably ok if we only support 19041 until then, just curious if that was intentional or not.

"16299",
"15063",
"14393"
"19041"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Are we sure all those other versions should be removed from the allowlist, not just 20348?

In other words, have you tested each single one of those and removed them all because you validated that 19041 was indeed the only one remaining valid? Or did you remove them all just because you considered it was not worth the effort for us to allow/support those older versions and didn't want to bother?

(I'm fine with either, just curious)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could go for something like:

$allowedVersions = @(
    # Windows 11 SDK
    "22621",
    "22000", 
    # Windows 10 SDK
    "19041",
    "18362"
)

As these are the Windows SDK versions that are included in the workload "WinUI application development build tools".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I know Windows 11 choices would make it fail as is but it's something to iterate on later)

Copy link
Contributor Author

@twstokes twstokes Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly because I don't think they're available either judging by only 19041 showing when searching with the GUI. I also don't think it's worth the effort to support them, although going forward I can see where we'd keep 19041 and then start adding Windows 11 SDKs.

Screenshot 2025-08-05 at 20 40 50

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh got it 👍 makes sense.

Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@twstokes twstokes merged commit e3a2e3a into trunk Aug 6, 2025
27 of 28 checks passed
@twstokes twstokes deleted the twstokes/win-sdk branch August 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants