-
Notifications
You must be signed in to change notification settings - Fork 5
Only use Windows SDK 19041 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
687cde8
to
af7f90b
Compare
af7f90b
to
20ff1e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock, but left a question.
I guess the plan is to soon support Win11 SDK anyway (in a separate PR with some refactor etc), so it's probably ok if we only support 19041
until then, just curious if that was intentional or not.
"16299", | ||
"15063", | ||
"14393" | ||
"19041" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Are we sure all those other versions should be removed from the allowlist, not just 20348?
In other words, have you tested each single one of those and removed them all because you validated that 19041
was indeed the only one remaining valid? Or did you remove them all just because you considered it was not worth the effort for us to allow/support those older versions and didn't want to bother?
(I'm fine with either, just curious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could go for something like:
$allowedVersions = @(
# Windows 11 SDK
"22621",
"22000",
# Windows 10 SDK
"19041",
"18362"
)
As these are the Windows SDK versions that are included in the workload "WinUI application development build tools".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I know Windows 11 choices would make it fail as is but it's something to iterate on later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh got it 👍 makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes AINFRA-1096
Windows 10 SDK 20348 doesn't appear available for download via the VS code bootstrapping tool, but
19041 still works.
CHANGELOG.md
if necessary.