Calendar: Remove 'taxonomy hierarchical' from editable fields for performance and usability #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cut a new release from develop
…formance and usability Re: Automattic#756 Stop hierarchical taxonomies like categories from being edited inside the calendar, while continuing to allow non-hierarchical taxonomies (tags) to be edited. This avoids the horrific performance punishment on sites with many categories due to the full list of categories being inserted as a hidden field inside each and every post on the calendar. It also avoids using a single-select field to update categories, which removes all categories but the one chosen when saved. Users are better off editing the post directly if they need to change the categories, at least unless and until we can offer a proper multi-select category picker in the calendar (a terrible idea because of the performance issues mentioned above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #756
Stop hierarchical taxonomies like categories from being edited inside the calendar, while continuing to allow non-hierarchical taxonomies (tags) to be edited.
This avoids the horrific performance punishment on sites with many categories due to the full list of categories being inserted as a hidden field inside each and every post on the calendar.
It also avoids using a single-select field to update categories, which removes all categories but the one chosen when saved. Users are better off editing the post directly if they need to change the categories, at least unless and until we can offer a proper multi-select category picker in the calendar (a terrible idea because of the performance issues mentioned above).