Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the new profile block #28

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Release the new profile block #28

merged 10 commits into from
Oct 23, 2024

Conversation

wellyshen
Copy link
Contributor

@wellyshen wellyshen commented Oct 18, 2024

Description

  • Replace the old block with the new one
  • Customize / update blocks' icon
  • Customize inner blocks' name
  • Clean up code
  • Update the plugin's version
  • Update the changelog
  • (Extra) Improve the migration logic a little bit (Self-tested already)
  • (Extra) Fix lint errors

Testing instructions

截圖 2024-10-21 下午5 22 11 截圖 2024-10-21 下午4 49 59

@wellyshen wellyshen self-assigned this Oct 18, 2024
@wellyshen wellyshen force-pushed the release-new-profile-block branch from 24a4c7d to 65ade10 Compare October 19, 2024 11:55
@wellyshen wellyshen marked this pull request as draft October 19, 2024 14:31
@wellyshen wellyshen marked this pull request as ready for review October 21, 2024 08:51
@wellyshen wellyshen force-pushed the release-new-profile-block branch from 53e1109 to c8cefe7 Compare October 21, 2024 09:20
@wellyshen wellyshen requested review from a team and removed request for johngodley and aaronfc October 23, 2024 13:41
Copy link
Contributor

@aaronfc aaronfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looking good. Left some minor comments along the code.

Also, you are missing the version changes in gravatar-enhanced.php. Something like:

diff --git a/gravatar-enhanced.php b/gravatar-enhanced.php
index 66777dc..9591746 100644
--- a/gravatar-enhanced.php
+++ b/gravatar-enhanced.php
@@ -4,7 +4,7 @@ Plugin Name: Gravatar Enhanced
 Plugin URI: https://wordpress.org/extend/plugins/gravatar-enhanced/
 Description: Enhanced functionality for Gravatar-ifying your WordPress site. Once you've enabled the plugin, go to the "Avatars" section on the <a href="options-discussion.php">Discussion Settings page</a> to get started.
 Author: Automattic
-Version: 0.4.0
+Version: 0.5.0
 License: GPLv2
 License URI: https://www.gnu.org/licenses/gpl-2.0.html
 Requires at least: 6.6
@@ -12,7 +12,7 @@ Requires PHP: 7.4
 */

 define( 'GRAVATAR_ENHANCED_PLUGIN_FILE', __FILE__ );
-define( 'GRAVATAR_ENHANCED_VERSION', '0.3.0' );
+define( 'GRAVATAR_ENHANCED_VERSION', '0.5.0' );

 if ( version_compare( phpversion(), '7.4' ) >= 0 ) {
        require_once __DIR__ . '/classes/class-plugin.php';

In one of my tests I set the background black and the social icons were barely visible. Is there anything we can do to fix that?
image

Tests I made:

  • ✅ Old blocks are correctly migrated to new block.
  • ✅ Playing around with styles in editor
  • ✅ Style changes are visible in view

I am approving. Just make sure you update the versions in gravatar-enhanced.php before you merge :) – good job! 🚀

readme.txt Outdated
@@ -87,6 +87,9 @@ A: It sends a single, polite email to commenters without Gravatars, inviting the

== Changelog ==

= 0.5.0 =
* Release Gravatar profile block v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we focus on the feature instead of the version?
Something like:

* Make Gravatar profile block customizable (v0.2.0) 

"supports": {
"html": false,
"align": true,
"html": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd identation

}
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd identation here too.

@wellyshen
Copy link
Contributor Author

@aaronfc Thank you for the code review, I have updated the versions.

In one of my tests I set the background black and the social icons were barely visible. Is there anything we can do to fix that?

It's a bit complicated, but I have created a relevant ticket to document and explain the issue.

@wellyshen wellyshen merged commit af7d182 into trunk Oct 23, 2024
@wellyshen wellyshen deleted the release-new-profile-block branch October 23, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants