-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release the new profile block #28
Conversation
24a4c7d
to
65ade10
Compare
53e1109
to
c8cefe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looking good. Left some minor comments along the code.
Also, you are missing the version changes in gravatar-enhanced.php
. Something like:
diff --git a/gravatar-enhanced.php b/gravatar-enhanced.php
index 66777dc..9591746 100644
--- a/gravatar-enhanced.php
+++ b/gravatar-enhanced.php
@@ -4,7 +4,7 @@ Plugin Name: Gravatar Enhanced
Plugin URI: https://wordpress.org/extend/plugins/gravatar-enhanced/
Description: Enhanced functionality for Gravatar-ifying your WordPress site. Once you've enabled the plugin, go to the "Avatars" section on the <a href="options-discussion.php">Discussion Settings page</a> to get started.
Author: Automattic
-Version: 0.4.0
+Version: 0.5.0
License: GPLv2
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Requires at least: 6.6
@@ -12,7 +12,7 @@ Requires PHP: 7.4
*/
define( 'GRAVATAR_ENHANCED_PLUGIN_FILE', __FILE__ );
-define( 'GRAVATAR_ENHANCED_VERSION', '0.3.0' );
+define( 'GRAVATAR_ENHANCED_VERSION', '0.5.0' );
if ( version_compare( phpversion(), '7.4' ) >= 0 ) {
require_once __DIR__ . '/classes/class-plugin.php';
In one of my tests I set the background black and the social icons were barely visible. Is there anything we can do to fix that?
Tests I made:
- ✅ Old blocks are correctly migrated to new block.
- ✅ Playing around with styles in editor
- ✅ Style changes are visible in view
I am approving. Just make sure you update the versions in gravatar-enhanced.php
before you merge :) – good job! 🚀
readme.txt
Outdated
@@ -87,6 +87,9 @@ A: It sends a single, polite email to commenters without Gravatars, inviting the | |||
|
|||
== Changelog == | |||
|
|||
= 0.5.0 = | |||
* Release Gravatar profile block v0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we focus on the feature instead of the version?
Something like:
* Make Gravatar profile block customizable (v0.2.0)
src/block/block.json
Outdated
"supports": { | ||
"html": false, | ||
"align": true, | ||
"html": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd identation
src/block/block.json
Outdated
} | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd identation here too.
@aaronfc Thank you for the code review, I have updated the versions.
It's a bit complicated, but I have created a relevant ticket to document and explain the issue. |
Description
Testing instructions
demo
eIActRARRkaEJYRBl6XY