Skip to content

fix: detect verse in competitor comparisons - #3983

Open
hydraxman wants to merge 1 commit into
Automattic:masterfrom
hydraxman:fix/verse-comparison-marker
Open

fix: detect verse in competitor comparisons#3983
hydraxman wants to merge 1 commit into
Automattic:masterfrom
hydraxman:fix/verse-comparison-marker

Conversation

@hydraxman

Copy link
Copy Markdown
Contributor

Note

This pull request was created with the assistance of an LLM.

Summary

  • detect verse used as a comparison marker before a proper competitor name
  • preserve the existing verse verb-form corrections and avoid broad single-word replacement

Problem

VerseAsVerb only recognized fixed phrases such as verse against and missed the reported comparison: Civic verse twin turbo Lamborghini. This leaves users without the intended versus correction.

The added path requires a capitalized competitor before verse and a proper noun at the end of the opposing phrase, limiting false positives for ordinary noun uses of verse.

Testing

  • cargo test -p harper-core --lib — 6,092 passed, 290 ignored
  • cargo clippy -p harper-core --lib -- -D warnings — passed
  • cargo fmt --check — passed
  • git diff --check — passed

Fixes #3966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerseAsVerb doesn't flag some cases

2 participants