fix: detect verse in competitor comparisons - #3983
Open
hydraxman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This pull request was created with the assistance of an LLM.
Summary
verseused as a comparison marker before a proper competitor nameverseverb-form corrections and avoid broad single-word replacementProblem
VerseAsVerbonly recognized fixed phrases such asverse againstand missed the reported comparison:Civic verse twin turbo Lamborghini. This leaves users without the intendedversuscorrection.The added path requires a capitalized competitor before
verseand a proper noun at the end of the opposing phrase, limiting false positives for ordinary noun uses ofverse.Testing
cargo test -p harper-core --lib— 6,092 passed, 290 ignoredcargo clippy -p harper-core --lib -- -D warnings— passedcargo fmt --check— passedgit diff --check— passedFixes #3966