-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: fix excerpt panel styles #41814
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Current spacing on the Excerpt panel:
![image](https://private-user-images.githubusercontent.com/157240/413407789-eab7f13e-e41a-4983-ba78-4254a20eb83c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NTM4NzMsIm5iZiI6MTczOTk1MzU3MywicGF0aCI6Ii8xNTcyNDAvNDEzNDA3Nzg5LWVhYjdmMTNlLWU0MWEtNDk4My1iYTc4LTQyNTRhMjBlYjgzYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOVQwODI2MTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MDg3OWJhNmEwOTFhMjk1ZTViOWJiZDQzMzlkODA4N2MzMDAzOWM5NDEzODNhY2I2ZGVkMzMzNzJlYWZmODhiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ahe3CxriHMKhP9nZODyIycEiD4I-6bg7A_eG9LVjd98)
Proposed changes:
This PR addresses some wee issues on the styles and adds deprecation props on the components.
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Create a new post, look for the excerpt panel on the Post sidebar. It should have better spacing than on the above screenshot: