Skip to content

Conversation

@manzoorwanijk
Copy link
Member

Extracted out of #46102 to demonstrate how to wire up the edit template modal

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • After following the instructions in Social: Integrate the unified modal for preview #46102
  • Expand the Customize section
  • Click on the "Edit template" button
  • Confirm that it opens the dummy Social image template screen
  • Close the modal
  • Enable Social Image Generator toggle
  • Notice the dummy "Edit template" button under it
  • Click on it
  • Confirm that it opens the same unified modal with the screen locked, i.e. there is no back button
Screen.Recording.2025-11-26.at.5.45.49.PM.mov

@manzoorwanijk manzoorwanijk self-assigned this Nov 27, 2025
@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Nov 27, 2025
@manzoorwanijk manzoorwanijk marked this pull request as draft November 27, 2025 05:22
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/social/edit-template-modal branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/social/edit-template-modal

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 27, 2025

Code Coverage Summary

No summary data is available for parent commit 1da0424, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 1da0424 is available.

Full summary · PHP report · JS report

@manzoorwanijk manzoorwanijk force-pushed the add/social/edit-template-modal branch from 4a68330 to c54d45a Compare November 27, 2025 10:55
Base automatically changed from add/social/unified-modal to trunk December 2, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Components [JS Package] Publicize Components RNA [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants