Forms: replace jetpack buttons with core #46166

CGastrell · 2025-12-02T15:24:33Z

This is a takeover from #45007

Proposed changes:

Following the original PR, this is a simpler approach just using core/button to replace jetpack/button

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

(verbatim from original PR)

Existing post smoke-test
- Open a post containing a Contact Form created before this patch (uses Jetpack Button).
- Confirm there are no editor errors; publish / update.
- View front-end and submit the form – it should behave as it always did.
New form
- Insert a fresh Contact Form block.
- Verify the submit control is a Core Button in a Core Buttons wrapper.
- Publish and submit on the front-end – spinner, disable state and success/error handling should work.
Variations
- Insert each Contact-Form variation (RSVP, Registration, Feedback, etc.).
- Confirm each uses a Core Button and submits correctly.
Editor layout
- Editing experience should respect the different core/block options when saving.

Replaces usage of the custom jetpack/button block with the core/buttons and core/button blocks for submit actions in the contact form. Updates block variations, editor logic, and server-side rendering to support and enhance compatibility with core/buttons, including interactivity attributes and error handling. This change improves alignment with WordPress core blocks and future-proofs the contact form implementation.

Introduces a spinner animation to the submit button when the form is submitting by adding CSS for a loading indicator and keyframes for the spinner effect.

Co-authored-by: Mikael Korpela <[email protected]>

Co-authored-by: Manzoor Wani <[email protected]>

…form-block.php Co-authored-by: Manzoor Wani <[email protected]>

github-actions · 2025-12-02T15:25:37Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-12-02T15:25:38Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the replace/forms-jetpack-buttons-core branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack replace/forms-jetpack-buttons-core

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jp-launch-control · 2025-12-02T15:35:41Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/blocks/contact-form/edit.tsx	0/275 (0.00%)	0.00%	3 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form.php	894/1298 (68.88%)	-0.11%	2 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	518/605 (85.62%)	3.19%	-17 💚

Full summary · PHP report · JS report

_{Coverage check overridden by

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR
.}

lezama · 2025-12-02T18:11:02Z

projects/packages/forms/src/contact-form/class-util.php

                        <!-- wp:jetpack/field-textarea {"label":"Notes"} /-->
-                        <!-- wp:jetpack/button {"element":"button","text":"Book Appointment","lock":{"remove":true}} /-->
+						<!-- wp:button {"tagName":"button","type":"submit","className":"jetpack-form-submit-button"} -->
+							<div class="wp-block-button jetpack-form-submit-button"><button type="submit" class="wp-block-button__link wp-element-button">Book Appointment</button></div>


Do we need to specify the html?

lezama and others added 18 commits December 2, 2025 11:56

simpler

f369861

Restrict flex styling to specific wp-block elements

4852242

Add spinner animation for submitting form button

56c598f

Introduces a spinner animation to the submit button when the form is submitting by adding CSS for a loading indicator and keyframes for the spinner effect.

Restrict tag processing to button and update submit styles

7a75e1e

changelog

1e69f30

Update projects/packages/forms/src/blocks/contact-form/variations.js

c0397ef

Co-authored-by: Mikael Korpela <[email protected]>

Refactor render_submit_button to improve clarity

0926b68

Update projects/packages/forms/src/blocks/contact-form/variations.js

d0e83c0

Co-authored-by: Mikael Korpela <[email protected]>

add some tests to improve coverage

7562ba3

fix disabled and submitting states

4328e9d

update tests after attribute addition

ca8bf82

modify useformwrapper to use core/buttons as well

9e5f4f6

Apply suggestion from @manzoorwanijk

695e26d

Co-authored-by: Manzoor Wani <[email protected]>

Update projects/packages/forms/src/blocks/contact-form/class-contact-…

4bb6a2d

…form-block.php Co-authored-by: Manzoor Wani <[email protected]>

change patterns to use core buttons

4cd837b

switch core/buttons for core/button

8c15289

changelog

cb69dff

CGastrell self-assigned this Dec 2, 2025

github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Tests] Includes Tests labels Dec 2, 2025

make core buttons take the same styles as previous jetpack buttons

ef3b913

CGastrell force-pushed the replace/forms-jetpack-buttons-core branch from 82662a1 to ef3b913 Compare December 2, 2025 15:53

lezama reviewed Dec 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: replace jetpack buttons with core #46166

Forms: replace jetpack buttons with core #46166

CGastrell commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

lezama Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Forms: replace jetpack buttons with core #46166

Are you sure you want to change the base?

Forms: replace jetpack buttons with core #46166

Conversation

CGastrell commented Dec 2, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

lezama Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 2, 2025 •

edited

Loading

jp-launch-control bot commented Dec 2, 2025 •

edited

Loading