fix(modal-checkout): import change payment class #2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
approved these changes
Nov 19, 2025
miguelpeixe
deleted the
fix/modal-checkout-change-payment-class-import
branch
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Nov 27, 2025
# [4.19.0-alpha.1](v4.18.0...v4.19.0-alpha.1) (2025-11-27) ### Bug Fixes * add a max-width to the Content Carousel block ([#2253](#2253)) ([b791a3a](b791a3a)) * handle checkout form inline errors and expired sessions ([#2255](#2255)) ([9beb64e](9beb64e)) * linting issues ([#2254](#2254)) ([776514b](776514b)) * **modal-checkout:** require change payment class ([#2257](#2257)) ([4d606ef](4d606ef)) ### Features * **donate-block:** default frequency for tiered layout ([#2248](#2248)) ([df0e2f9](df0e2f9))
Contributor
|
🎉 This PR is included in version 4.19.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
NPPD-983
At some point, probably while resolving merge conflicts, the new class introduced in #2141 to handle "change payment" via modal checkout got removed. This PR restores it
How to test the changes in this Pull Request:
Repeat steps from Automattic/newspack-plugin#4016
Other information: