fix: avoid redeclaration of global function #2264
Open
+52
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Avoids a possible redeclaration fatal if the thankyou.php custom template is loaded more than once. Related to Automattic/newspack-plugin#4251.
How to test the changes in this Pull Request:
trunkof this repo, complete a modal checkout transaction on a page that renders content gates.PHP Fatal error: Cannot redeclare Newspack_Blocks\newspack_blocks_replace_login_with_order_summary() (previously declared in /newspack-repos/newspack-blocks/src/modal-checkout/templates/thankyou.php:33) in /newspack-repos/newspack-blocks/src/modal-checkout/templates/thankyou.php on line 33Other information: