fix: add check for newsletter modal and fix typo (#3727)

Automattic · Feb 7, 2025 · 5fdcab6 · 5fdcab6
1 parent f91803a
commit 5fdcab6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/includes/plugins/wc-memberships/class-memberships.php b/includes/plugins/wc-memberships/class-memberships.php
@@ -774,7 +774,7 @@ public static function render_js() {
 					if ( ev.detail.authenticated && ! window?.newspackReaderActivation?.getPendingCheckout() ) {
 						if ( ras.overlays.get().length ) {
 							ras.on( 'overlay', function( ev ) {
-								if ( ! ev.detail.overlays.length ) {
+								if ( ! ev.detail.overlays.length && ! window?.newspackReaderActivation?.openNewslettersSignupModal ) {
 									window.location.reload();
 								}
 							} );

diff --git a/src/reader-activation/index.js b/src/reader-activation/index.js
@@ -193,7 +193,7 @@ export function openNewslettersSignupModal( config = {} ) {
 	config = {
 		...{
 			onSuccess: null,
-			onDissmiss: null,
+			onDismiss: null,
 			onError: null,
 			initialState: null,
 			skipSuccess: false,