Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newsletters Lists indentation #2797

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Fixes a regression created by Automattic/newspack-newsletters#1255 that broke changes introduced by #2424. In the Newsletters PR, the group is no longer returned with type=mailchimp-group.

How to test the changes in this Pull Request:

  1. Make sure you have Mailchimp set up and there are some groups
  2. Visit Newspack Engagement
  3. See that the groups are indented under their Audiences

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 7, 2023
@leogermani leogermani self-assigned this Dec 7, 2023
@leogermani leogermani requested a review from a team as a code owner December 7, 2023 19:46
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 22, 2023
@leogermani leogermani merged commit 1af3c23 into master Dec 22, 2023
2 checks passed
@leogermani leogermani deleted the fix/lists-indentation branch December 22, 2023 14:06
matticbot pushed a commit that referenced this pull request Dec 22, 2023
# [2.13.0-alpha.2](v2.13.0-alpha.1...v2.13.0-alpha.2) (2023-12-22)

### Bug Fixes

* newsletters Lists indentation ([#2797](#2797)) ([1af3c23](1af3c23))
* **ras:** remove modal checkout logic ([#2781](#2781)) ([6aad17d](6aad17d))
* use Woo's cart fee for covering transaction fees ([#2820](#2820)) ([fded027](fded027))

### Features

* add media partners module ([#2753](#2753)) ([70f7dcb](70f7dcb))
* **donation:** additional receipt email template variables ([#2799](#2799)) ([0c9c373](0c9c373))
* force option to enble retries of failed payments ([#2808](#2808)) ([f8d35ec](f8d35ec))
* give editors permission for restricted content ([#2806](#2806)) ([64d7817](64d7817))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.13.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 8, 2024
# [2.13.0](v2.12.2...v2.13.0) (2024-01-08)

### Bug Fixes

* alpha fixes ([#2835](#2835)) ([49efd8b](49efd8b))
* newsletters Lists indentation ([#2797](#2797)) ([1af3c23](1af3c23))
* **ras:** remove modal checkout logic ([#2781](#2781)) ([6aad17d](6aad17d))
* use Woo's cart fee for covering transaction fees ([#2820](#2820)) ([fded027](fded027))

### Features

* add media partners module ([#2753](#2753)) ([70f7dcb](70f7dcb))
* don’t send OTP via preauth flow when signing up for newsletter ([#2795](#2795)) ([686af03](686af03))
* **donation:** additional receipt email template variables ([#2799](#2799)) ([0c9c373](0c9c373))
* force allow subscription switching ([#2784](#2784)) ([ae7523f](ae7523f))
* force option to enble retries of failed payments ([#2808](#2808)) ([f8d35ec](f8d35ec))
* give editors permission for restricted content ([#2806](#2806)) ([64d7817](64d7817))
* **my-account:** support edit address ([#2733](#2733)) ([92d5778](92d5778))
* remove commenting from engagement tab ([#2726](#2726)) ([f51c7bc](f51c7bc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants