-
Notifications
You must be signed in to change notification settings - Fork 297
Finalize and publish release in CI + various automation updates #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to use the `BUILDKITE_` prefix workaround.
This way, we'll always be sure the gems resolved to a version that includes this new feature we want to use: `buildkite_pipeline_upload`
Collaborator
Generated by 🚫 Danger |
The previous AppCenter version failed the build with a "rsync.samba" error due to it having script sandboxing enabled. Noticed that: - The only breaking change from version 4 to 5 is the change in minimum deployment target. See https://github.com/microsoft/appcenter-sdk-apple/blob/8b039c9de609bd58ea7526c60954194cd1b3a94e/CHANGELOG.md#version-500 - The App Store build does not import AppCenter - AppCenter will be decommissioned in March 2025
Collaborator
|
| App Name | ||
| Build Number | pr1668-d3fa5fa-0192d77a-9b4c-42d3-9366-ec68542f7e52 | |
| Version | 4.54 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | d3fa5fa | |
| App Center Build | Simplenote - Installable Builds #393 |
Contributor
Author
|
The UI tests failed. But that cannot be due to the AppCenter version changes (and of course the release automation) because the build that runs the UI tests does not import AppCenter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_VERSIONat the pipeline YAML level instead of readingBUILDKITE_RELEASE_VERSIONin the script.publish_releaselanebuildkite_pipeline_uploadcreate_backmerge_prs!from Simplenote Android