Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on site health screen #34

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

JanJakes
Copy link
Contributor

Information schema subqueries need to provide the actual database name, so that parent queries that compare against it return some data.

Fixes:

Warning: Undefined array key "wp_comments" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_options" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_posts" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_terms" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_users" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586

Information schema subqueries need to provide the actual database name,
so that parent queries that compare against it return some data.

Fixes:

Warning: Undefined array key "wp_comments" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_options" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_posts" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_terms" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Undefined array key "wp_users" in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
Warning: Attempt to read property "rows" on null in /var/www/html/wp-admin/includes/class-wp-site-health.php on line 3586
@JanJakes JanJakes force-pushed the fix-site-health-warnings branch from 84ae93e to 6e83c19 Compare March 25, 2025 16:02
@JanJakes JanJakes requested a review from bgrgicak March 25, 2025 16:23
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks clear, and fixes the issue.

@JanJakes JanJakes merged commit 6452601 into develop Mar 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants