Database configuration and migration #42
Conversation
JanJakes
force-pushed
the
driver-migration
branch
2 times, most recently
from
6148a0b to
2250ed3
Compare
JanJakes
force-pushed
the
driver-migration
branch
from
2250ed3 to
12d3063
Compare
JanJakes
force-pushed
the
driver-migration
branch
4 times, most recently
from
7d2c0c1 to
6e94ae8
Compare
JanJakes
force-pushed
the
driver-migration
branch
from
6e94ae8 to
ed959fb
Compare
|
|
||
| jobs: | ||
| verify-version: | ||
| name: Verify plugin version |
There was a problem hiding this comment.
What's that workflow? Let's document its purpose inline or give it a name that explains the intent
| @@ -12,6 +12,12 @@ | |||
| * @package wp-sqlite-integration | |||
| */ | |||
|
|
|||
| /** | |||
| * Load the "SQLITE_DRIVER_VERSION" constant. | |||
| * This constant needs to be updated whenever the plugin version changes! | |||
| private $sqlite; | ||
|
|
||
| public static function setUpBeforeClass(): void { | ||
| // if ( ! defined( 'PDO_DEBUG' )) { |
| $GLOBALS['wpdb']->show_errors = true; | ||
| } | ||
|
|
||
| // Mock symols that are used for WordPress table reconstruction. |
There was a problem hiding this comment.
| // Mock symols that are used for WordPress table reconstruction. | |
| // Mock symbols that are used for WordPress table reconstruction. |
| // In WordPress, use "wp_get_db_schema()" to reconstruct WordPress tables. | ||
| $wp_tables = array(); | ||
| if ( defined( 'ABSPATH' ) ) { | ||
| if ( wp_installing() ) { |
There was a problem hiding this comment.
Let's add some context on why would this run during wp installation
| // Avoid interfering with WordPress installation. | ||
| return; | ||
| } | ||
| if ( file_exists( ABSPATH . 'wp-admin/includes/schema.php' ) ) { |
There was a problem hiding this comment.
If we're in WordPress context and that file is missing, should that be a fatal error?
| || str_ends_with( $data_type, 'blob' ) | ||
| ) { | ||
| $cols[] = sprintf( | ||
| '%s(%d)', |
There was a problem hiding this comment.
At least decimal, timestamp, and datetime fields can also have parentheses with additional parameters. Maybe others too. Should we consider them here?
| } | ||
| if ( | ||
| "''" === $default_value | ||
| && in_array( strtolower( $mysql_type ), array( 'datetime', 'date', 'time', 'timestamp', 'year' ), true ) |
There was a problem hiding this comment.
What's the rationale here? Let's document it
| } | ||
| throw $e; | ||
| } | ||
| if ( str_ends_with( $mysql_type, ' KEY' ) ) { |
There was a problem hiding this comment.
What are some values that would trigger this condition? Let's document that inline.
| if ( str_contains( $type, 'INT' ) ) { | ||
| return 'int'; | ||
| } | ||
| if ( str_contains( $type, 'TEXT' ) || str_contains( $type, 'CHAR' ) || str_contains( $type, 'CLOB' ) ) { |
There was a problem hiding this comment.
This came up for me as I read it: CLOB? Or BLOB? Also, in another line of this file we do strtolower and test for str_ends_with, let's be consistent here if that makes sense.
Then I've remembered sqlite uses substring to match a data type. And clob is actually a char type. Still, let's document that inline. These are all non-obvious behaviors
| } else { | ||
| $unquoted = $quoted_identifier; | ||
| } | ||
| return str_replace( $first_byte . $first_byte, $first_byte, $unquoted ); |
There was a problem hiding this comment.
Let's only run that replace in the if branch where that first byte is a quote, otherwise we risk corrupting byte sequences such as strassberg
|
Great start! And also a good idea to use a cascade of data sources for backfilling. There's some more way to go, though — I've commented on a bunch of potential issues |
This PR extracts existing SQLite database configuration to a
WP_SQLite_Configuratorand implementsWP_SQLite_Information_Schema_Reconstructorwith the ability to backfill missing table data in information schema.How it works:
WP_SQLite_Configurator::ensure_database_configured()), while acquiring anEXCLUSIVElock to prevent race conditions (multiple requests triggering the same migration).WP_SQLite_Information_Schema_Reconstructor.wp_get_db_schema()._mysql_data_types_cache, if it exists, otherwise directly from the SQLite schema using SQLite column affinity rules.