Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Studio: Change the position of the create preview button #918

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Studio: Change the position of the create preview button #918

wants to merge 2 commits into from
+23 −25

Conversation

sejas
Copy link
Member

@sejas sejas commented Feb 11, 2025

Related issues

Proposed Changes

  • We move the button below the table to avoid bad "align" positions between the add site and create preview buttons
  • The button gets sticky at the bottom when the table grows enough.

Testing Instructions

  • Run npm start
  • Go to the Previews tab
  • Create a preview site, observe the button below the table
  • Create two or three more sites and observe the button sticky at the bottom.

Before

image

After

image

image

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Feb 11, 2025
@sejas sejas requested a review from a team February 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sejas sejas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sejas