-
Notifications
You must be signed in to change notification settings - Fork 1
Update view mode #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ingeniumed
wants to merge
5
commits into
trunk
Choose a base branch
from
add/view-mode-part-2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−185
Open
Update view mode #113
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1b8e448
Inert the sidebar
ingeniumed d80ed8e
Use the new mode from within GB
ingeniumed 1e9faa4
Disable sidebar interaction entirely in viewing mode
ingeniumed 17ed187
Merge branch 'trunk' of github.com:Automattic/vip-real-time-collabora…
ingeniumed 5558b4e
Compute the collaboration mode picker value dynamically
ingeniumed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { store as coreDataStore, type CoreDataSelectors } from '@wordpress/core-data'; | ||
| import { useSelect } from '@wordpress/data'; | ||
| import { useEffect } from '@wordpress/element'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { | ||
| Setting, | ||
| store as rtcSettingsStore, | ||
| type SettingsStoreSelectors, | ||
| } from '@/store/settings-store'; | ||
|
|
||
| /** | ||
| * Custom hook that disables sidebar interaction when in view mode. | ||
| */ | ||
| export function useDisableSidebarInteraction() { | ||
| // Get the current collaboration mode (view or edit). | ||
| const currentCollaborationEditorMode = useSelect< CoreDataSelectors, 'view' | 'edit' >( select => | ||
| select( coreDataStore ).getCollaboratorMode() | ||
| ); | ||
|
|
||
| // Check if the Collaboration Mode Picker setting is enabled. | ||
| // TODO: Delete this once we complete the feature. | ||
| const isCollaborationModeEnabled = useSelect< SettingsStoreSelectors, boolean >( select => | ||
| select( rtcSettingsStore ).getSetting( Setting.COLLABORATION_MODE_PICKER ) | ||
| ); | ||
|
|
||
| const shouldSidebarBeReadOnly = | ||
| isCollaborationModeEnabled && currentCollaborationEditorMode === 'view'; | ||
|
|
||
| // Manage sidebar interaction. | ||
| useEffect( () => { | ||
| const sidebarElement = document.querySelector( '.editor-sidebar' ); | ||
| const headerSettingsElement = document.querySelector( '.editor-header__settings' ); | ||
|
|
||
| if ( | ||
| sidebarElement instanceof HTMLDivElement && | ||
| headerSettingsElement instanceof HTMLDivElement | ||
| ) { | ||
| sidebarElement.style.pointerEvents = shouldSidebarBeReadOnly ? 'none' : 'auto'; | ||
| headerSettingsElement.style.pointerEvents = shouldSidebarBeReadOnly ? 'none' : 'auto'; | ||
| } | ||
| }, [ shouldSidebarBeReadOnly ] ); | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ const DEFAULT_STATE: SettingsState = { | |
| [ Setting.POST_UPDATE_NOTIFICATION ]: true, | ||
| [ Setting.USER_ENTER_NOTIFICATION ]: true, | ||
| [ Setting.USER_EXIT_NOTIFICATION ]: false, | ||
| [ Setting.COLLABORATION_MODE_PICKER ]: false, | ||
| [ Setting.COLLABORATION_MODE_PICKER ]: isDevelopment() ? true : false, | ||
|
||
| }; | ||
|
|
||
| // Settings that are only available in development mode | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try locking post saving, and auto saving instead of doing this. That is not the best solution because if the pre-publish panel is enabled, then any changes made there result in UI quirks. This could include a tag not saving for example which wouldn't be the best experience.
The thought I had is that, we can slowly remove each CSS tweak as we make changes within Gutenberg to allow native "read only" modes everywhere.