fix: attribute selection from PDPs with tokenized ECE #10306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +24 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
frosso
commented
Feb 12, 2025
| @@ -37,14 +37,16 @@ addFilter( | |||
| 'wcpay.express-checkout.cart-add-item', | |||
| 'automattic/wcpay/express-checkout', | |||
| ( productData ) => { | |||
| const $variationInformation = jQuery( '.single_variation_wrap' ); | |||
| if ( ! $variationInformation.length ) { | |||
| const variationInformation = document.querySelector( | |||
There was a problem hiding this comment.
I moved away from the jQuery selectors and switched to vanilla JS selectors, so that testing would be more reliable and easier (without having to mock jQuery)
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10303
Changes proposed in this Pull Request
Plugins like "Variation Swatches for WooCommerce" might alter the page's HTML structure, causing the ECE to not be able to parse the selected variation on a product page.
When such thing occurs, the
POST cart/add-itemcall fails to get the product prices when the all the product variation attributes are selected.Testing instructions
Repeat the above steps with the "Variation Swatches for WooCommerce" plugin.
Repeat the above steps with these changes to your local
wp-content/plugins/woocommerce/src/StoreApi/Utilities/CartController.phpfile.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge