Skip to content

Fix: Invalidate retries with the invalidation of an Outbox Item #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2025

Conversation

pfefferle
Copy link
Member

This PR also invalidates all retries for an invalidated Outbox-Item.

This is nearly impossible to test, because phpunit does not let me create schedules.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Properly remove retries schedules, with the invalidation of an Outbox-Item.

@pfefferle pfefferle self-assigned this Mar 28, 2025
@pfefferle pfefferle added the [Type] Bug Something isn't working label Mar 28, 2025
@pfefferle pfefferle requested a review from a team March 28, 2025 10:55
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfefferle I understand you technically can't approve the changes I made, but it would be good if you could still review and test them on your end.

I updated it to use the new hook name, consolidate schedule management in the Scheduler, and add a unit test to make sure it works.

@pfefferle pfefferle merged commit d166b9f into trunk May 13, 2025
11 checks passed
@pfefferle pfefferle deleted the fix/invalidate-retries branch May 13, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants