Skip to content

Add in_reply_to Actor to Activity audience #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2025
Merged

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented May 16, 2025

Part of #1698 fixes #1712

Proposed changes:

  • Add the Actor of the replied post in cc or to, depending on the visibility.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Publish a new post with a reply-block
  • Load the post-url with ?activitypub
  • Check the JSON output for the Actor of the replied URL

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

The actor of the replied-to post is now included in cc or to based on the post's visibility.

@pfefferle pfefferle requested a review from Copilot May 16, 2025 10:55
@pfefferle pfefferle self-assigned this May 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to include the actor referenced by "in_reply_to" in the activity's audience.

  • Integrates retrieval of the "in_reply_to" actor via a new HTTP call.
  • Updates audience composition to add the "in_reply_to" actor across different content visibility cases.

@pfefferle pfefferle marked this pull request as ready for review May 16, 2025 12:57
@pfefferle pfefferle requested a review from obenland May 16, 2025 12:57
@pfefferle pfefferle requested a review from obenland May 19, 2025 16:36
@pfefferle pfefferle merged commit 8479c49 into trunk May 20, 2025
11 checks passed
@pfefferle pfefferle deleted the add/reply-audience branch May 20, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a reply, add user that's being replied to in cc.
3 participants