Fix promise and add timeout for more resilience

Automattic · Feb 6, 2025 · e1ad8dd · e1ad8dd
1 parent fab519b
commit e1ad8dd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/calypso-e2e/src/lib/pages/signup/user-signup-page.ts b/packages/calypso-e2e/src/lib/pages/signup/user-signup-page.ts
@@ -154,10 +154,13 @@ export class UserSignupPage {
 	async signupWoo( email: string ): Promise< NewUserResponse > {
 		await this.page.fill( selectors.emailInput, email );
 
-		const [ , response ] = await Promise.all( [
-			this.page.waitForURL( /.*woocommerce\.com*/, { waitUntil: 'networkidle' } ),
-			this.page.waitForResponse( /.*new\?.*/ ),
+		const [ response ] = await Promise.all( [
+			this.page.waitForResponse( /.*users\/new\?.*/ ),
 			this.page.click( selectors.submitButton ),
+			this.page.waitForURL( /.*woocommerce\.com*/, {
+				waitUntil: 'networkidle',
+				timeout: 25000,
+			} ),
 		] );
 
 		if ( ! response ) {

diff --git a/test/e2e/specs/onboarding/signup__woo-email.ts b/test/e2e/specs/onboarding/signup__woo-email.ts
@@ -55,7 +55,7 @@ describe(
 			} );
 
 			it( 'Activate account', async function () {
-				await page.goto( activationLink, { waitUntil: 'networkidle' } );
+				await page.goto( activationLink, { waitUntil: 'networkidle', timeout: 25000 } );
 			} );
 		} );
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,7 +55,7 @@ describe( @@
     			} );
     			it( 'Activate account', async function () {
-    				await page.goto( activationLink, { waitUntil: 'networkidle' } );
+    				await page.goto( activationLink, { waitUntil: 'networkidle', timeout: 25000 } );
     			} );
     		} );
@@ Expand Down @@