-
Notifications
You must be signed in to change notification settings - Fork 2k
Update more v2 plan links to use the plans-grid flow #106553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Update more v2 plan links to use the plans-grid flow #106553
Conversation
This change updates the new billing dashboard as well as the overview plan card for free sites to point to /setup/plan-upgrade so that the user can choose the plan on the distraction-less plans-grid.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
if ( purchase.is_plan ) { | ||
return getWpcomPlanGridUrl( purchase.site_slug ); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure that this is the best way to detect "This is a wpcom plan". Any tips @brandonpayton ?
|
||
return `/plans/${ purchase.site_slug }`; | ||
if ( purchase.is_jetpack_plan_or_product ) { | ||
return `/plans/${ purchase.site_slug }`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a separate issue that I'll open on Monday, but mentioning here for now because I came across it while testing.
I don't think we should be linking to /plans for Jetpack sites. It looks ugly to the point of brokenness:
Currently we don't link to this page from anywhere - it's not in the navigation, it's not in /sites and it's not on the existing purchase page.
The existing purchase page seems to link to different things for different Jetpack plans e.g. Jetpack Growth links to checkout for Jetpack Complete, and Jetpack Security links to /plans/storage/:siteSlug. I guess we need to use the same logic here for Jetpack plans.
Part of DOTCOM-14978
Proposed Changes
This change updates the new billing dashboard as well as the overview plan card for free sites to point to /setup/plan-upgrade
Why are these changes being made?
So that the user can choose the plan on the distraction-less plans-grid rather than the old grid presented in the site context.
Testing Instructions
Billing Dashboard
Screen.Recording.2025-10-17.at.15.37.59.mov
Site overview
Screen.Recording.2025-10-17.at.15.35.54.mov
To be thorough, test also with other sites/purchases e.g. a Jetpack plan.
Pre-merge Checklist