Skip to content

Conversation

tx2pnw
Copy link
Contributor

@tx2pnw tx2pnw commented Oct 17, 2025

Resolves #SHILL-1215

Proposed Changes

  • allow purchase to load even if there is no site associated with it.

Why are these changes being made?

Purchases without a site do not load in the hosting dashboard:
http://calypso.localhost:3000/v2/me/billing/purchases/1170154
Screenshot 2025-10-17 at 10 34 03 AM

Testing Instructions

  1. Purchase a siteless jetpack add-on from here: https://jetpack.com/upgrade/anti-spam
  2. Navigate to http://calypso.localhost:3000/v2/me/billing/purchases and click
    Jetpack Akismet Anti-spam to manage the purchase.
  3. Verify that the Purchase details load
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Oct 17, 2025

@tx2pnw tx2pnw requested a review from a team October 17, 2025 19:54
@tx2pnw tx2pnw self-assigned this Oct 17, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2025
@tx2pnw tx2pnw marked this pull request as ready for review October 17, 2025 19:56
@tx2pnw tx2pnw requested a review from a team as a code owner October 17, 2025 19:56
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/SHILL-1215-siteless-purchases on your sandbox.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Very nice.

Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants