Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Remove email restrictions for Gravatar domains #99380

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Feb 5, 2025

Related to https://github.com/Automattic/nomado-issues/issues/1243

Proposed Changes

This PR removes email restrictions from Gravatar domains. This means that now free Gravatar domains can have Professional email attached to them if the user pays for it.

This PR basically reverts the Professional email restrictions added in #96085.

This is part of the Gravatar Domains i3 project (pcYYhz-2vx-p2).

Why are these changes being made?

We want to allow free Gravatar domain owners to attach email to their domains, but only if they pay for it in order to prevent abuse.

Testing Instructions

This depends on 172418-ghe-Automattic/wpcom.

Go to the domain management page for a domain that has both the usage_gravatar and usage_gravatar_restricted domain flags

  • Ensure the Professional email purchase CTA is shown on the right column:

Markup on 2025-02-06 at 09:43:08

  • Ensure the free 3-month introductory offer is not available:

Markup on 2025-02-06 at 09:43:43

  • Ensure the checkout price also looks correct:

Markup on 2025-02-06 at 09:44:11

Now try to purchase Professional email for a domain that has only the usage_gravatar flag, i.e. it's a free Gravatar domain that was renewed.

  • Ensure the 3-month introductory offer is available:

Markup on 2025-02-06 at 09:47:43

  • Ensure the introductory offer is also correct in checkout:

Markup on 2025-02-06 at 09:48:04

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@leonardost leonardost self-assigned this Feb 5, 2025
@leonardost leonardost requested a review from a team as a code owner February 5, 2025 22:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/email-restrictions-for-gravatar-domains on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~200 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
hosting        -817 B  (-0.0%)     -200 B  (-0.0%)
domains        -817 B  (-0.0%)     -200 B  (-0.0%)
email          -796 B  (-0.1%)     -201 B  (-0.1%)
checkout       -524 B  (-0.0%)     -126 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants