Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Remove invalid test after Settings > Media untangling #99393

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Feb 6, 2025

Related to #

Proposed Changes

We redirect Settings > Media to wp-admin for 90% users, so this test can be considered obsolete now.

Testing Instructions

yarn workspace wp-e2e-tests test -- test/e2e/specs/media/settings__media.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@fushar fushar marked this pull request as ready for review February 6, 2025 03:32
@fushar fushar requested a review from a team February 6, 2025 03:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@fushar fushar self-assigned this Feb 6, 2025
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fushar fushar merged commit fb86ffd into trunk Feb 6, 2025
16 checks passed
@fushar fushar deleted the fix/e2e-settings-media branch February 6, 2025 03:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
anomiex added a commit that referenced this pull request Feb 6, 2025
PR #99393 switched from clicking the link in Calypso to visiting
wp-admin directly. On Atomic this runs into the SSO login screen.
Copy-paste the workaround used in other tests to avoid that.
anomiex added a commit that referenced this pull request Feb 6, 2025
PR #99393 switched from clicking the link in Calypso to visiting
wp-admin directly. On Atomic this runs into the SSO login screen.
Copy-paste the workaround used in other tests to avoid that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants