Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Marketplace: Fix WordPress.com hosting discount calculation #99394

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Feb 6, 2025

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1751

Proposed Changes

This PR fixes the WordPress.com hosting discount calculation while using the Number Input component. It converts the value from the OnChange event to a number, as the previously provided value was a string.

Why are these changes being made?

  • To fix the wrongly calculated discount for WordPress.com hosting.

Testing Instructions

  • Open the A4A live link
  • Go to Marketplace: Hosting > Go to Standard Agency Hosting tab > Click the + button on the Number Input and verify that the discount is as per the number of plans added, not the max discount. Also, verify the pointer on the slider is not at the right place(as per the no of plans), not at the end.
Before After
Screenshot 2025-02-06 at 10 33 43 AM Screenshot 2025-02-06 at 10 33 41 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team February 6, 2025 05:06
@yashwin yashwin self-assigned this Feb 6, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 6, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace        +19 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -1,4 +1,3 @@
// eslint-disable-next-line wpcalypso/no-unsafe-wp-apis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@travisw travisw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice fix

@yashwin yashwin merged commit 32fb2ad into trunk Feb 7, 2025
17 of 20 checks passed
@yashwin yashwin deleted the fix/a4a/marketplace/wordpress-hosting-discount branch February 7, 2025 03:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants