Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Fix connections layout issues #99417

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Feb 6, 2025

Related to https://github.com/Automattic/jetpack-reach/issues/737

Proposed Changes

  • Hid examples for already connected services -- c4df792
  • Added back missing css to have grid -- 5d07ad1

Testing Instructions

  • Check the connections management page /marketing/connections/<site_url>
  • For connected accounts you should not see the examples.
  • Examples should break into 2 columns on large screens, and 1 on small ones

CleanShot 2025-02-06 at 16 50 27 png

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gmjuhasz gmjuhasz added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@gmjuhasz gmjuhasz requested a review from a team February 6, 2025 15:50
@gmjuhasz gmjuhasz self-assigned this Feb 6, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/social-connections-example-layout on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-marketing        +21 B  (+0.0%)       +4 B  (+0.0%)
marketing             +21 B  (+0.0%)       +4 B  (+0.0%)
jetpack-social        +21 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on Calypso, but it's still wonky of Jetpack Cloud. I know it will be hardly used now, but it would be good fix it in both places.

CleanShot 2025-02-06 at 21 37 11@2x

I'm also not sure about the fonts there. Might be something to look at while we're there.

Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a huge issue, but in Calypso we are seeing this 'Connect one more account' button below the examples, when no accounts are connected. It's not there in Jetpack Cloud.

CleanShot 2025-02-07 at 16 19 52@2x

@gmjuhasz gmjuhasz merged commit 945a8fc into trunk Feb 10, 2025
13 checks passed
@gmjuhasz gmjuhasz deleted the fix/social-connections-example-layout branch February 10, 2025 12:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants