Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader - fix 0 at bottom of loading following stream. #99431

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Feb 6, 2025

Related to # #99427

Proposed Changes

  • converts items.length in the rendering logic check to be a boolean value, so it doesn't drop a 0 in the page.

BEFORE
Screenshot 2025-02-06 at 2 37 32 PM

AFTER
Screenshot 2025-02-06 at 2 33 23 PM

Why are these changes being made?

  • It was dropping a 0 in the page.

Testing Instructions

  • Test the /reader feed and verify there is no longer a 0 at the bottom.
  • You can use devtools to throttle network speed if needed, or you can adjust the forcePlaceholders value in the code
  • Visit the bottom of your recent stream (or select an individual site under recent, but there must be some posts), and verify the footer still shows up after scrolling to the bottom of the feed.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner February 6, 2025 19:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@Addison-Stavlo Addison-Stavlo self-assigned this Feb 6, 2025
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue! Thanks for opening the PR!

@Addison-Stavlo Addison-Stavlo merged commit 7dfc0a0 into trunk Feb 6, 2025
16 checks passed
@Addison-Stavlo Addison-Stavlo deleted the fix/0-beneath-reader-recent-loading-state branch February 6, 2025 19:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants