Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Locations: update i18n tooltip string #99439

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Feb 6, 2025

Related to p1738867503025649-slack-CEM18K8LT

Proposed Changes

  • Update i18n string for Locations' module tooltip (added an apostrophe at the end of "Visitors").

Why are these changes being made?

p1738867503025649-slack-CEM18K8LT

Testing Instructions

  • Spin up a Calypso Live Branch
  • Navigate to Stats page
  • Click on the Locations module tooltip and ensure the string is updated

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Initsogar Initsogar changed the title Update i18n tooltip string Stats Locations: update i18n tooltip string Feb 6, 2025
@Initsogar Initsogar self-assigned this Feb 6, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-locations-tooltip-translation on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@Initsogar Initsogar merged commit 99aaa10 into trunk Feb 7, 2025
16 checks passed
@Initsogar Initsogar deleted the update/stats-locations-tooltip-translation branch February 7, 2025 00:34
@a8ci18n
Copy link

a8ci18n commented Feb 7, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17233186

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @Initsogar, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Visitors’ {{link}}viewing location{{/link}} by countries, regions and cities.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Feb 9, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants