Remove Is Reskinned Flag: Completely cleanup domains of the isReskinned flag

[ddc22]

Related to: #95419

Proposed Changes

• Renames the isReskinned flag used for hiding domain match reasons to hideMatchReasons
• Renames the isReskinned flag used for the different layout used in Onboarding flows as isOnboarding
• Renames the isReskinned flag used for the flag related to showing domain transfer suggestions to showDomainTransferSuggestion
• Minor bugfix for when there are no match reasons

Broken margin bottom near Free for ...	Fixed

Why are these changes being made?

• Codebase cleanup from invasive flag

Testing Instructions

• Check /setup/onboarding/domains make sure the domains page mimicks production
• Go to the domains add page and make sure /domains/add it mimicks production
• On domains add page search for a term which shows no match results (Test) and make sure the layout is fixed

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132510

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132510&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132510&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
domains                     +50 B  (+0.0%)      +23 B  (+0.0%)
update-design-flow          +48 B  (+0.0%)      +21 B  (+0.0%)
link-in-bio-tld-flow        +48 B  (+0.0%)      +20 B  (+0.0%)
copy-site-flow              +48 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2963 bytes removed 📉 [gzipped])

name                                    parsed_size            gzip_size
async-load-signup-steps-site-or-domain      -9191 B  (-12.9%)    -2577 B  (-11.4%)
async-load-signup-steps-domains              -865 B   (-0.1%)     -386 B   (-0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ddc22]

We return the empty element to maintain proper form of the layout.