Publish a Blog: Add feature flag and pass it to site creation endpoint #99484
Conversation
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
| @@ -212,7 +215,7 @@ const CreateSite: Step = function CreateSite( { navigation, flow, data } ) { | |||
| }; | |||
| } | |||
|
|
|||
| const siteIntent = isMigrationSignupFlow( flow ) ? 'migration' : ''; | |||
| const siteIntent = isMigrationSignupFlow( flow ) ? 'migration' : intent; | |||
There was a problem hiding this comment.
For some reason we're not setting the intent on site creation, only when exiting the flow in /setup/site-setup. That means if the user bails after the processing screen they'll have an empty intent option.
I don't think this is right. Why save the goals and not the intent? Let's save both.
There was a problem hiding this comment.
It's because when we first started with intent, the goals screen was always after site creation. I also don't think we need to use intent for this project so we don't need this hcnage: see my comment on the backend.
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~333 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| @@ -212,7 +215,7 @@ const CreateSite: Step = function CreateSite( { navigation, flow, data } ) { | |||
| }; | |||
| } | |||
|
|
|||
| const siteIntent = isMigrationSignupFlow( flow ) ? 'migration' : ''; | |||
| const siteIntent = isMigrationSignupFlow( flow ) ? 'migration' : intent; | |||
There was a problem hiding this comment.
It's because when we first started with intent, the goals screen was always after site creation. I also don't think we need to use intent for this project so we don't need this hcnage: see my comment on the backend.
| @@ -234,7 +237,8 @@ const CreateSite: Step = function CreateSite( { navigation, flow, data } ) { | |||
| domainItem, | |||
| sourceSlug, | |||
| siteIntent, | |||
| shouldSaveSiteGoals ? siteGoals : undefined | |||
| shouldSaveSiteGoals ? siteGoals : undefined, | |||
| config.isEnabled( 'onboarding/write-goal' ) | |||
There was a problem hiding this comment.
Should we also do a treatment_cumulative check here?
Closes #99453.
Testing Instructions
Checkout 172681-ghe-Automattic/wpcom in your sandbox and proxy yourself.
/setup/onboardingwriteintent on the site)/settings/newsletter/%sand verify that the "Add the Subscribe Block at the end of each post." toggle is ON.Create a site in a different flow or by picking different goals and verify that the the toggle is OFF in the Newsletter settings.