Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update translations that include the product name #99485

Merged
merged 16 commits into from
Feb 11, 2025

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Feb 7, 2025

Proposed Changes

Updates occurrences of "Jetpack Stats" to avoid translation.

Why are these changes being made?

Per discussion in Slack, we shouldn't be translating the product name.

Testing Instructions

  • Launch the Calypso Live environment and browse the main Stats pages to confirm the product name appears correctly.
  • Test the Purchase flows.
  • Test the upsells.
  • more…

I did not manually confirm the copy in each of the upsell/purchase flows or all of the possible notices so if you can test one of those, that would be helpful. I did test the Enable Stats notice, the permissions error notice, and the each of the standard dashboard tabs.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~59 bytes added 📈 [gzipped])

name                            parsed_size           gzip_size
stats                                +248 B  (+0.0%)      +22 B  (+0.0%)
plugins                               +27 B  (+0.0%)      +14 B  (+0.0%)
media                                 +27 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-agency-dashboard        +27 B  (+0.0%)      +12 B  (+0.0%)
google-my-business                    +27 B  (+0.0%)      +11 B  (+0.0%)
backup                                +27 B  (+0.0%)      +12 B  (+0.0%)
activity                              +27 B  (+0.0%)      +12 B  (+0.0%)
a8c-for-agencies-sites                +27 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~77 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-purchase          +191 B  (+0.3%)      +46 B  (+0.3%)
async-load-store-app-store-stats-listview                  +47 B  (+0.0%)      +22 B  (+0.1%)
async-load-store-app-store-stats                           +47 B  (+0.0%)      +22 B  (+0.0%)
async-load-calypso-my-sites-stats-pages-insights           -28 B  (-0.0%)       -7 B  (-0.0%)
async-load-design-playground                               +27 B  (+0.0%)      +14 B  (+0.0%)
async-load-design-blocks                                   +27 B  (+0.0%)      +14 B  (+0.0%)
async-load-design                                          +27 B  (+0.0%)      +14 B  (+0.0%)
async-load-calypso-post-editor-media-modal                 +27 B  (+0.0%)      +14 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal          +27 B  (+0.0%)      +14 B  (+0.0%)
async-load-calypso-my-sites-stats-wordads                  +18 B  (+0.1%)       +1 B  (+0.0%)
async-load-calypso-my-sites-stats-pages-subscribers        +11 B  (+0.0%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ck3n a8ck3n self-assigned this Feb 7, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 7, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-do-not-translate-product-name on your sandbox.

@a8ck3n a8ck3n marked this pull request as ready for review February 10, 2025 09:03
@a8ck3n a8ck3n requested a review from a team February 10, 2025 09:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those! LGTM 👍

@a8ck3n a8ck3n changed the title Stats: Upate translations that include the product name Stats: Update translations that include the product name Feb 11, 2025
@a8ck3n a8ck3n merged commit ce95449 into trunk Feb 11, 2025
14 checks passed
@a8ck3n a8ck3n deleted the update/stats-do-not-translate-product-name branch February 11, 2025 07:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2025
@a8ci18n
Copy link

a8ci18n commented Feb 11, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17242607

Some locales (Brazilian Portuguese, Dutch, Hebrew, Japanese, Spanish) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @a8ck3n, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Enable %(product)s
  • Upgrade your plan to unlock %(product)s.
  • Grow faster with %(product)s
  • Do you love %(product)s?
  • Want to get the most out of %(product)s?
  • Thank you for supporting %(product)s!
  • You already have a license for %(product)s.
  • Continue with %(product)s for free
  • Preview of the full %(product)s dashboard
  • Upgrade and continue using %(product)s
  • Support %(product)s and set your price

Thank you in advance!

@a8ck3n
Copy link
Contributor Author

a8ck3n commented Feb 12, 2025

Hi @a8ck3n, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

In all cases the changes are removing "Jetpack Stats" from the translation and adding it as an argument. The end result is the same string, but we do not want the "Jetpack Stats" part translated as its the product name.

For example, a Swedish user should see "Jetpack Stats" and not "Jetpack-statistik" or similar. Likewise, a Japanese user should see "Jetpack Stats" and not "ジェットパック統計".

As for screenshots, that would be upwards of 20 screenshots, some of which are not easily exposed in the UI (part of error notices, upgrade notices, checkout flow, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants