-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Update translations that include the product name #99485
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~59 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~77 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those! LGTM 👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17242607 Some locales (Brazilian Portuguese, Dutch, Hebrew, Japanese, Spanish) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @a8ck3n, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
In all cases the changes are removing "Jetpack Stats" from the translation and adding it as an argument. The end result is the same string, but we do not want the "Jetpack Stats" part translated as its the product name. For example, a Swedish user should see "Jetpack Stats" and not "Jetpack-statistik" or similar. Likewise, a Japanese user should see "Jetpack Stats" and not "ジェットパック統計". As for screenshots, that would be upwards of 20 screenshots, some of which are not easily exposed in the UI (part of error notices, upgrade notices, checkout flow, etc). |
Proposed Changes
Updates occurrences of "Jetpack Stats" to avoid translation.
Why are these changes being made?
Per discussion in Slack, we shouldn't be translating the product name.
Testing Instructions
I did not manually confirm the copy in each of the upsell/purchase flows or all of the possible notices so if you can test one of those, that would be helpful. I did test the Enable Stats notice, the permissions error notice, and the each of the standard dashboard tabs.
Pre-merge Checklist