Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Add Jetpack required banner to Plugins section #99500

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

tiagonoronha
Copy link
Contributor

Screenshot 2025-02-07 at 19 34 42

Adds a banner informing users that Jetpack is required to manage plugins through the Plugin Management section.

Testing Instructions

  • Open the live link
  • Go to the Plugins section and confirm you see the banner as displayed above.
  • Confirm that you can dismiss it.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@tiagonoronha tiagonoronha requested a review from a team February 7, 2025 19:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/plugins/add-jetpack-banner on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~33 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper                -98 B  (-0.0%)      +35 B  (+0.0%)
entry-main                   -98 B  (-0.0%)      +19 B  (+0.0%)
entry-login                  -98 B  (-0.0%)      +21 B  (+0.0%)
entry-domains-landing        -98 B  (-0.0%)      +21 B  (+0.0%)
entry-browsehappy            -98 B  (-0.0%)      +21 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~938 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
jetpack-cloud-plugin-management      +3423 B  (+0.1%)    +1449 B  (+0.2%)
a8c-for-agencies-plugins             +3423 B  (+0.2%)    +1449 B  (+0.2%)
plugins                               +610 B  (+0.0%)     +294 B  (+0.0%)
transferring-hosted-site-flow         -196 B  (-0.1%)    -1580 B  (-1.8%)
plugin-bundle-flow                    -196 B  (-0.0%)    -1523 B  (-0.9%)
stepper-user-step                     +103 B  (+0.0%)      +25 B  (+0.0%)
newsletter-post-setup-flow            +103 B  (+0.0%)      +27 B  (+0.0%)
link-in-bio-post-setup-flow           +103 B  (+0.0%)      +27 B  (+0.0%)
jetpack-cloud-manage-pricing          +103 B  (+0.0%)      +24 B  (+0.0%)
entrepreneur-flow                     +103 B  (+0.1%)      +26 B  (+0.0%)
domain-user-transfer-flow             +103 B  (+0.0%)      +15 B  (+0.0%)
copy-site-flow                        +103 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~487 bytes added 📈 [gzipped])

name                                                            parsed_size           gzip_size
async-load-signup-steps-woocommerce-install-transfer                 +103 B  (+0.2%)      +14 B  (+0.1%)
async-load-signup-steps-woocommerce-install-step-store-address       +103 B  (+0.1%)      +14 B  (+0.0%)
async-load-signup-steps-woocommerce-install-step-business-info       +103 B  (+0.1%)      +13 B  (+0.0%)
async-load-signup-steps-woocommerce-install-confirm                  +103 B  (+0.1%)      +76 B  (+0.3%)
async-load-signup-steps-theme-selection                              +103 B  (+0.0%)      +15 B  (+0.0%)
async-load-signup-steps-test-step                                    +103 B  (+0.2%)      +15 B  (+0.1%)
async-load-signup-steps-social-profiles                              +103 B  (+0.2%)      +16 B  (+0.1%)
async-load-signup-steps-site-options                                 +103 B  (+0.1%)      +22 B  (+0.1%)
async-load-signup-steps-site                                         +103 B  (+0.1%)      +14 B  (+0.1%)
async-load-signup-steps-rewind-were-backing                          +103 B  (+0.2%)      +15 B  (+0.1%)
async-load-signup-steps-rewind-form-creds                            +103 B  (+0.1%)      +14 B  (+0.0%)
async-load-signup-steps-page-picker                                  +103 B  (+0.0%)      +12 B  (+0.0%)
async-load-signup-steps-initial-intent                               +103 B  (+0.1%)      +26 B  (+0.1%)
async-load-signup-steps-hosting-decider                              +103 B  (+0.2%)      +15 B  (+0.1%)
async-load-signup-steps-emails                                       +103 B  (+0.1%)      +15 B  (+0.1%)
async-load-signup-steps-domains                                      +103 B  (+0.0%)      +17 B  (+0.0%)
async-load-signup-steps-design-picker                                +103 B  (+0.1%)      +15 B  (+0.1%)
async-load-signup-steps-creds-permission                             +103 B  (+0.1%)      +15 B  (+0.1%)
async-load-signup-steps-creds-confirm                                +103 B  (+0.1%)      +16 B  (+0.1%)
async-load-signup-steps-courses                                      +103 B  (+0.1%)      +16 B  (+0.0%)
async-load-signup-steps-clone-start                                  +103 B  (+0.2%)      +12 B  (+0.1%)
async-load-signup-steps-clone-ready                                  +103 B  (+0.1%)      +14 B  (+0.1%)
async-load-signup-steps-clone-point                                  +103 B  (+0.0%)      +16 B  (+0.0%)
async-load-signup-steps-clone-destination                            +103 B  (+0.2%)      +15 B  (+0.1%)
async-load-signup-steps-clone-credentials                            +103 B  (+0.1%)      +14 B  (+0.0%)
async-load-signup-steps-clone-cloning                                +103 B  (+0.2%)      +12 B  (+0.1%)
async-load-design-playground                                         +103 B  (+0.0%)      +29 B  (+0.0%)
async-load-design                                                    +103 B  (+0.0%)      +29 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tiagonoronha tiagonoronha merged commit 7d92c4e into trunk Feb 10, 2025
13 checks passed
@tiagonoronha tiagonoronha deleted the a4a/plugins/add-jetpack-banner branch February 10, 2025 11:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
@a8ci18n
Copy link

a8ci18n commented Feb 10, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17241417

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @tiagonoronha for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants