Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Display chart with stable 30-minute series data #99557

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

dognose24
Copy link
Contributor

@dognose24 dognose24 commented Feb 10, 2025

Related to #99419

Proposed Changes

  • Generate a 30-minute data series as the stable display.
  • Adjust the tickFormat for the X-axis to display -0m ~ -30m labels.
  • Add yScale.domain to align 0 to the bottom of the Y-axis when no views are fetched.

Why are these changes being made?

  • A follow-up to tweak the real-time chart with data and options.

Testing Instructions

  • Spin this change up with the Calypso Live branch.
  • Navigate to Stats > Realtime tab with the feature flag: stats/real-time-tab.
  • Ensure the chart displays all 30 minutes of data with the correct view differences.
截圖 2025-02-11 凌晨1 30 23 截圖 2025-02-11 凌晨1 41 21

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dognose24 dognose24 added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 10, 2025
@dognose24 dognose24 requested review from kangzj and a team February 10, 2025 17:42
@dognose24 dognose24 self-assigned this Feb 10, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~176 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-realtime              +361 B  (+3.4%)      +98 B  (+2.7%)
async-load-calypso-my-sites-stats-components-line-chart       +128 B  (+0.0%)      +78 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@dognose24 dognose24 changed the title Stats: Modify chart data iteration and adjust chart options Stats: Display chart with stable 30-minute series data Feb 10, 2025
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Great work 👍

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug updat/stats_realtime_adjust_chart_data_and_options on your sandbox.

@kangzj kangzj merged commit bf63a18 into trunk Feb 11, 2025
11 of 13 checks passed
@kangzj kangzj deleted the updat/stats_realtime_adjust_chart_data_and_options branch February 11, 2025 22:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2025
JessBoctor pushed a commit that referenced this pull request Mar 13, 2025
* Modify chart data iteration and adjust chart options

* fix type error

---------

Co-authored-by: Jasper Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants