-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Display chart with stable 30-minute series data #99557
Stats: Display chart with stable 30-minute series data #99557
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~176 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Great work 👍
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
* Modify chart data iteration and adjust chart options * fix type error --------- Co-authored-by: Jasper Kang <[email protected]>
Related to #99419
Proposed Changes
tickFormat
for the X-axis to display-0m
~-30m
labels.yScale.domain
to align0
to the bottom of the Y-axis when no views are fetched.Why are these changes being made?
Testing Instructions
stats/real-time-tab
.Pre-merge Checklist