Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/taipy designer react #2418

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

dinhlongviolin1
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 commented Jan 21, 2025

Just 4 lines of code in designer to create the slider

const rootElement = document.getElementById('taipy-root');
const app = new TaipyApp();
app.createCanvas(rootElement);
app.addElement2Canvas('Slider', 'b', ['<div>', '</div>']);

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from d669466

Copy link
Contributor

github-actions bot commented Jan 21, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19631 17082 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 789640f by action🐍

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

frontend/taipy-gui/base/src/renderer/elementManager.ts Outdated Show resolved Hide resolved
frontend/taipy-gui/base/src/renderer/elementRenderer.ts Outdated Show resolved Hide resolved
frontend/taipy-gui/base/src/renderer/elementRenderer.ts Outdated Show resolved Hide resolved
frontend/taipy-gui/base/src/renderer/elementRenderer.ts Outdated Show resolved Hide resolved
frontend/taipy-gui/base/src/store.ts Show resolved Hide resolved
frontend/taipy-gui/package.json Show resolved Hide resolved
frontend/taipy-gui/package.json Show resolved Hide resolved
@FredLL-Avaiga FredLL-Avaiga self-requested a review January 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants