Running taipy in notebooks is slow#2704
Draft
KachanovYev wants to merge 8 commits intoAvaiga:developfrom
Draft
Conversation
Avaiga#2489-running-taipy-in-notebooks-is-slow
KachanovYev
changed the title
add type checker from None to Int
Contributor
Author
|
Hi, PR is ready. 3 jobs are canceled. |
Contributor
Author
|
Hi |
FredLL-Avaiga
requested changes
Aug 13, 2025
Member
FredLL-Avaiga
left a comment
FredLL-Avaiga
left a comment
There was a problem hiding this comment.
remove non necessary noqa comments
taipy/gui/config.py
Outdated
| _warn( | ||
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. Unable to parse value to the correct type", # noqa: E501 | ||
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. " | ||
| f"Unable to parse value to the correct type", |
Member
There was a problem hiding this comment.
no need for f string if it is cut ?
taipy/gui/config.py
Outdated
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. Unable to parse value to the correct type", # noqa: E501 | ||
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. " | ||
| f"Unable to parse value to the correct type", | ||
| # noqa: E501 |
Member
There was a problem hiding this comment.
no need to ignore E501 when the string is cut ?
| except Exception as e: | ||
| _warn( | ||
| f"Invalid env value in Gui.run(): {key} - {value}. Unable to parse value to the correct type", # noqa: E501 | ||
| f"Invalid env value in Gui.run(): {key} - {value}. " |
taipy/gui/servers/flask/server.py
Outdated
| "Something is wrong with the taipy-gui front-end installation. Check that the js bundle has been properly built (is Node.js installed?)." # noqa: E501 | ||
| "Something is wrong with the taipy-gui front-end installation. " | ||
| "Check that the js bundle has been properly built (is Node.js installed?)." | ||
| # noqa: E501 |
Member
There was a problem hiding this comment.
is "ignore E501" needed when the string is cut ?
taipy/gui/utils/proxy.py
Outdated
| message="You do not have a working installation of the service_identity module: 'No module named 'service_identity''.*", # noqa: E501 | ||
| message="You don't have a working installation of the service_identity module: " | ||
| "'No module named 'service_identity''.*", | ||
| # noqa: E501 |
Contributor
|
Can you please provide more details on how running the proxy as a thread will help with performance? |
Contributor
Author
Hi But before i got it. So, PR in progress |
FredLL-Avaiga
requested changes
Aug 14, 2025
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. Unable to parse value to the correct type", # noqa: E501 | ||
| e, | ||
| f"Invalid keyword arguments value in Gui.run(): {key} - {value}. " | ||
| f"Unable to parse value to the correct type: {e}", |
Member
There was a problem hiding this comment.
passing the exception as an argument is preferred
| except Exception as e: | ||
| _warn( | ||
| f"Invalid env value in Gui.run(): {key} - {value}. Unable to parse value to the correct type", # noqa: E501 | ||
| f"Invalid env value in Gui.run(): {key} - {value}. " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (Check all that apply)
Description
Resolve freezing when we are using jupyter
Related Tickets & Documents
How to reproduce the issue
Backporting
This change should be backported to:
Checklist
We encourage keeping the code coverage percentage at 80% or above.
If not, explain why:
If not, explain why:
If not, explain why:
If not, explain why: