-
Notifications
You must be signed in to change notification settings - Fork 1
Random seeding #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random seeding #84
Conversation
it's a specific regression test for #62 which was added in #63. It ensures this fix to If I remember correctly there was an issue when EDIT: So I believe what it's doing is checking we get the same results when playing the match multiple times. |
(But it's very poorly documented: that's my bad.) |
I believe I've fixed the test, which passes locally. But all the tests won't work here until we release a new version of |
…th the Axelrod library
…tegy name is supplied, the object doesn't teardown correctly
add2510
to
c0b630f
Compare
Axelrod-Python/Axelrod#1288 has been merged: I plan to do a new release first thing tomorrow (Wednesday) morning. |
Looks good to me 👍 Once we have a new release I'll get the simulations going for the reproducing paper 👍 |
@meatballs PTAL. We should release a new version of axelrod-fortran after this PR goes in. The CI checks don't show up for me on this page, you can see them passing here. |
Could be worth moving this to GitHub actions? I could have a go at putting that together. |
Sorry I hit request review from you @drvinceknight and cannot rescind it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do not merge, won't work until the random_seed branch of Axelrod is merged
I don't understand whattest_champion_v_alternator
is doing.