Skip to content

Random seeding #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2020
Merged

Random seeding #84

merged 9 commits into from
Aug 12, 2020

Conversation

marcharper
Copy link
Member

@marcharper marcharper commented Mar 12, 2020

Do not merge, won't work until the random_seed branch of Axelrod is merged

I don't understand what test_champion_v_alternator is doing.

@drvinceknight
Copy link
Member

drvinceknight commented Mar 13, 2020

don't understand what test_champion_v_alternator is doing.

it's a specific regression test for #62 which was added in #63. It ensures this fix to TourExec works: https://github.com/Axelrod-Python/TourExec/pull/6/files

If I remember correctly there was an issue when k61r played repeatedly (which probably wasn't picked up in the original Axelrod tournaments as they were no repetitions so to speak).

EDIT: So I believe what it's doing is checking we get the same results when playing the match multiple times.

@drvinceknight
Copy link
Member

EDIT: So I believe what it's doing is checking we get the same results when playing the match multiple times.

(But it's very poorly documented: that's my bad.)

@marcharper
Copy link
Member Author

I believe I've fixed the test, which passes locally. But all the tests won't work here until we release a new version of axelrod.

@drvinceknight
Copy link
Member

Axelrod-Python/Axelrod#1288 has been merged: I plan to do a new release first thing tomorrow (Wednesday) morning.

@drvinceknight
Copy link
Member

Looks good to me 👍 Once we have a new release I'll get the simulations going for the reproducing paper 👍

@marcharper
Copy link
Member Author

@meatballs PTAL. We should release a new version of axelrod-fortran after this PR goes in.

The CI checks don't show up for me on this page, you can see them passing here.

@drvinceknight
Copy link
Member

The CI checks don't show up for me on this page, you can see them passing here.

Could be worth moving this to GitHub actions? I could have a go at putting that together.

@marcharper
Copy link
Member Author

marcharper commented Aug 12, 2020

Sorry I hit request review from you @drvinceknight and cannot rescind it

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meatballs meatballs merged commit 8601e4e into master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants