Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow issue #195

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix overflow issue #195

merged 1 commit into from
Feb 12, 2024

Conversation

mentoc3000
Copy link
Contributor

Describe your changes

When assigning pointers to labelArray, if the file had a final, empty newline, the last element of labelArray would try to be assigned to a pointer to labelsData + labelsFileSize + 1, which can cause a warning that can disrupt inference:

malloc(): invalid size (unsorted)

I also removed the replacement of the final '\n' with '\0' because it is always done in the loop.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@mentoc3000 mentoc3000 requested a review from a team as a code owner February 7, 2024 20:42
@pataxis pataxis merged commit a0c1e9c into AxisCommunications:main Feb 12, 2024
3 checks passed
@pataxis
Copy link
Contributor

pataxis commented Feb 12, 2024

Thank you @mentoc3000 for your contribution, it's very appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants