Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align packages from react17 to react18 #225

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Conversation

axis-d0op
Copy link
Contributor

@axis-d0op axis-d0op commented Mar 13, 2024

After a recent dependabot update we got a mismatch in react versions, this pr aligns all packages to use react 18, from some using 17.

  • add global types for specs (wasn't checked before in ts?)
  • slider: fluent slots doesn't seem to work well with react 17+, though you can add a workaround for children props for input slot
    thumb.types.ts
  • fix react 18 render for examples/src/main.tsx

@axis-d0op axis-d0op requested a review from a team as a code owner March 13, 2024 13:30
@axis-d0op
Copy link
Contributor Author

hmmm verkar vara nått iissue liknande: microsoft/fluentui#26289

@axis-d0op axis-d0op force-pushed the align-to-react18 branch 2 times, most recently from e54e438 to 0e2da03 Compare March 14, 2024 18:28
@axis-d0op
Copy link
Contributor Author

await to merge until after next release to make it more isolated, rel 18.19.0+

@axis-d0op axis-d0op merged commit f58c2fc into main Mar 23, 2024
4 checks passed
@axis-d0op axis-d0op deleted the align-to-react18 branch March 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants