Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topbar types #245

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix topbar types #245

merged 2 commits into from
Apr 2, 2024

Conversation

NiklasRamstrom
Copy link
Contributor

@NiklasRamstrom NiklasRamstrom commented Apr 2, 2024

Describe your changes

After the alignment of react version, the exported types in topbar was broken.
This fixes the types.
Also, a prebuild step is added for topbar as it requires icons to be build.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@NiklasRamstrom NiklasRamstrom requested a review from a team as a code owner April 2, 2024 07:29
Copy link
Contributor

@axis-d0op axis-d0op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NiklasRamstrom NiklasRamstrom merged commit 6d40361 into main Apr 2, 2024
4 checks passed
@NiklasRamstrom NiklasRamstrom deleted the niklasra/imports branch April 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants