Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): handle firefox style without warning in chrome #259

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

NiklasRamstrom
Copy link
Contributor

@NiklasRamstrom NiklasRamstrom commented Apr 11, 2024

Describe your changes

New fix to the scroll conflicts with firefox and chrome.
There were browser warnings with the previous hack.

Issue ticket number and link

  • Fixes #(issue)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@NiklasRamstrom NiklasRamstrom requested a review from a team as a code owner April 11, 2024 13:25
Copy link
Contributor

@axis-d0op axis-d0op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgt

@NiklasRamstrom NiklasRamstrom force-pushed the niklasra/new-scroll-fix branch from 8fa3ba3 to a2504b2 Compare April 11, 2024 13:35
@NiklasRamstrom NiklasRamstrom enabled auto-merge (squash) April 11, 2024 13:35
@NiklasRamstrom NiklasRamstrom merged commit c5a50da into main Apr 11, 2024
4 checks passed
@NiklasRamstrom NiklasRamstrom deleted the niklasra/new-scroll-fix branch April 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants