Add webRTC video #919
Closed
Add webRTC video #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielkaxis
commented
Feb 28, 2024
danielkaxis
commented
- Devices can send video over webRTC and media-stream-library-js has to support this.
- Add webRTC connection by using browser RTCPeerConnection to a specific target
- Add currently supported parameters.
- Add easy example player with a form to input credentials. For ease of use, these credentials are stored in localStorage.
danielkaxis
requested review from
barnomasoz,
steabert and
Tigge
as code owners
Add documenation for webRTC
lekoaf
reviewed
Feb 28, 2024
| this.ws.close(1000, 're-initializing connection') | ||
| } | ||
|
|
||
| const baseUrl = `wss://signaling.${this.env}.webrtc.connect.axis.com/client` |
There was a problem hiding this comment.
So this is hardcoded to Axis "internal" webrtc client?
Why not allow someone to use their own and let them specify a baseUrl?
I'm especially not fond of passing around environments and let that be the only thing someone can specify.
lekoaf
reviewed
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.