Re-introduce yarn and replace dprint/eslint with biome #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed as we're not committing NPM dependencies as *.zip to the repository.
Fairly large maintenance-related changes, but no code changes, aimed at simplifying maintenance. Unfortunately, while the change to npm was an attempt at using more default tooling, the additional burden when updating packages, and the need to rely on a third-party tool (bringing in lots of new dependencies) turned out to be not great. This re-introduces yarn, but it's kept at v3 (instead of latest stable v4), because of dependabot support. Another high-maintenance area is linting, with eslint needing extensive configuration. This is now replaced with biome. And because the latter also has a formatter, dprint is also removed.
steabert
force-pushed
the
next
branch
2 times, most recently
from
00263b9 to
6b2e67a
Compare
Tigge
reviewed
Apr 2, 2024
Formatting-only changes produced by running `just biome format --write .` on the repo.
Auto-fixable changes produced by running `just biome check --apply .` in the repo.
Fixes a few issues caught by the linter, or disables rules that are currently not passing the linter.
Tigge
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the goal of further simplifying maintenance, eslint/dprint are replaced with biome.
Furthermore, during those changes it became more painfully obvious that updating packages
in a monorepo with
npmis annoying at best, and inconsistent at worst.Therefore, in the same sweep, yarn is re-introduced, however this time without zero-install
or the need for LFS, which keeps things much simpler overall.
Since these are all related somehow this was kept in the same PR, but it should be merged
as a proper merge commit to keep the history (there are only a very few code changes, and they
are isolated in a separate commit).
Checklist for review